-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allows cycle to be a tuple #87
allows cycle to be a tuple #87
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. This needs a test as well.
Pinged a little too early -- it was a bit of a rabbit hole I went into but I think this should be correct. |
My guess is that the Cycle object itself is an iterate so you need to move that case statement above the one with Iterable or add a new case statement after the one that catches Cycle objects. |
Good catch. That fixed it. Results look good now. The failure relates to a missing test and a fixed error. |
That helped a ton. There is one failure in the box plots that needs investigating. |
Ah so the new boxplot plot is the correct one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming the new boxplot is correct, Lgtm!
New one is correct I think. Thanks will push some styling and then merge it. |
Fixes #86